Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(expect): objectContaining should recurse into sub-objects #10508

Merged
merged 2 commits into from
Oct 20, 2020
Merged

fix(expect): objectContaining should recurse into sub-objects #10508

merged 2 commits into from
Oct 20, 2020

Conversation

ioancole
Copy link
Contributor

Addressing bug report #10462. According to the docs, objectContaining should apply in a recursive sense, however it doesn't seem to do this currently.

Summary

This change will make objectContaining work recursively into sub-objects.

Test plan

Included a unit test for the new behavior, and confirmed that all older tests still pass.

@facebook-github-bot
Copy link
Contributor

Hi @ioancole!

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.

In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

2 similar comments
@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wonderful, thanks!

@SimenB
Copy link
Member

SimenB commented Sep 14, 2020

Ergh, seems CI is unhappy 😅 Would you be able to take a look?

@ioancole
Copy link
Contributor Author

Hey Simen, thanks for looking at this so quickly. The only check failing now is the windows-latest test run on a seemingly completely unrelated DOM test, and this check passed on a previous push to this PR. Is there a way to re-run the CI pipeline? I think this will pass on a re-run. Thanks!

@SimenB
Copy link
Member

SimenB commented Sep 14, 2020

Yeah, that failure looks like flake. I'll retrigger CI 👍

@SimenB
Copy link
Member

SimenB commented Oct 19, 2020

@ioancole sorry, this seems to produce a type error. Could you take a look?

@ioancole
Copy link
Contributor Author

Hey! It's fixed now. Thanks again

@SimenB SimenB changed the title Make objectContaining recursive into sub-objects fix(expect): objectContaining should recurse into sub-objects Oct 20, 2020
@SimenB SimenB merged commit 9a07781 into jestjs:master Oct 20, 2020
@SimenB
Copy link
Member

SimenB commented Oct 20, 2020

Thanks @ioancole!

jyunhan pushed a commit to jyunhan/jest that referenced this pull request Oct 20, 2020
This was referenced Mar 12, 2021
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants